Skip to content

Conversation

@oliverklee
Copy link
Collaborator

We find those checks useful.

@oliverklee oliverklee self-assigned this Dec 17, 2024
@oliverklee oliverklee marked this pull request as draft December 17, 2024 09:03
@coveralls
Copy link

coveralls commented Dec 17, 2024

Coverage Status

coverage: 55.808%. remained the same
when pulling a3264c5 on task/assertinstanceof
into 86aeaa7 on main.

@oliverklee oliverklee force-pushed the task/assertinstanceof branch from 08906d1 to dbef139 Compare December 17, 2024 12:11
@JakeQZ
Copy link
Collaborator

JakeQZ commented Dec 17, 2024

Looks like this just needs a baseline update to remove the instanceof error which is now squished by the config change...

@oliverklee
Copy link
Collaborator Author

Looks like this just needs a baseline update to remove the instanceof error which is now squished by the config change...

I tried that: It turns out that we currently do not have any of those warnings (I tend to put this on the fact that PHPStan is still at level 1 for this project), and blocklisting warnings we don't have (yet) is something that PHPStan does not support.

So I'll keep this PR sitting here for the time being and un-draft it once we actually have any of those warnings to ignore.

@JakeQZ
Copy link
Collaborator

JakeQZ commented Dec 19, 2024

Looks like this just needs a baseline update to remove the instanceof error which is now squished by the config change...

we currently do not have any of those warnings

Ah, I see. I misunderstood the error message (did not read it properly), and thought it was referring to an existing error that now needed to be removed from the baseline.

@oliverklee oliverklee force-pushed the task/assertinstanceof branch from dbef139 to 6370fe4 Compare December 20, 2024 09:51
@oliverklee oliverklee force-pushed the task/assertinstanceof branch from 6370fe4 to 5d8b941 Compare January 27, 2025 08:40
@oliverklee oliverklee force-pushed the task/assertinstanceof branch 10 times, most recently from 309ceb6 to 53d5394 Compare February 16, 2025 21:18
@oliverklee oliverklee force-pushed the task/assertinstanceof branch 7 times, most recently from f62df6e to 3ac988f Compare February 25, 2025 08:47
@oliverklee oliverklee force-pushed the task/assertinstanceof branch 4 times, most recently from 0e7e4f9 to b572710 Compare February 27, 2025 11:21
@oliverklee oliverklee force-pushed the task/assertinstanceof branch 7 times, most recently from 9556834 to a414406 Compare March 2, 2025 14:09
We find those checks useful.
@oliverklee oliverklee force-pushed the task/assertinstanceof branch from a414406 to a3264c5 Compare March 3, 2025 10:18
@oliverklee oliverklee closed this Mar 3, 2025
@oliverklee oliverklee deleted the task/assertinstanceof branch March 3, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants